Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support context cancellation in file store #803

Merged
merged 2 commits into from
Aug 20, 2024
Merged

feat: support context cancellation in file store #803

merged 2 commits into from
Aug 20, 2024

Conversation

lucasrod16
Copy link
Contributor

Closes #619

@lucasrod16
feat: support context cancellation in file store
c8b6ec3 
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.94%. Comparing base (d9e1d43) to head (66bf5e9).
Report is 1 commits behind head on main.

Files Patch % Lines
content/file/file.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   77.88%   77.94%   +0.06%     
==========================================
  Files          63       63              
  Lines        4694     4698       +4     
==========================================
+ Hits         3656     3662       +6     
+ Misses        657      656       -1     
+ Partials      381      380       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wwwsylvia
Wwwsylvia reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasrod16 Thank you for the contribution! Code changes LGTM.
Can we add some unit tests and make sure the diff coverage reaches 80%?

@lucasrod16
add unit test for tarDirectory
66bf5e9 
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
@lucasrod16
Copy link
Contributor Author

lucasrod16 commented Aug 16, 2024 •
edited
Loading

@lucasrod16 Thank you for the contribution! Code changes LGTM. Can we add some unit tests and make sure the diff coverage reaches 80%?

@Wwwsylvia Yes! I added a unit test for tarDirectory. I tried to verify the coverage locally with codecov-cli but ran into errors about requiring a token for uploading the report

Wwwsylvia
Wwwsylvia approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 606f636 into oras-project:main Aug 20, 2024
9 checks passed
@lucasrod16 lucasrod16 deleted the 619-support-context-cancel-in-file-store branch August 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File store to support context cancel
3 participants
@lucasrod16 @Wwwsylvia @shizhMSFT